feat: add two-factor authentication support to login #1465
Conversation
Introduces two-factor authentication (2FA) for login via a new token input window and related UI changes. Updates server configuration to enable/disable authenticator per server, modifies login flow to handle token entry and error feedback, and passes the token to HTTP login requests in both Lua and C++. Refactors server list management to securely store account/password per server, and improves error handling and response parsing in HTTP login. Also adds a method to persist settings and fixes OTML parser edge cases for URLs ending with colons.
dudantas
changed the title
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local host, path = G.host, "/" | ||
| if G.host:find("https?://") then | ||
| local url = G.host:gsub("https?://", "") | ||
| host, path = url:match("([^/]+)(/.*)") |
There was a problem hiding this comment.
The new HTTP login parsing only splits host/path when the host string starts with http:// or https://. For hosts entered without a scheme (e.g. example.com/login.php), path now stays /, so the login request goes to the root instead of login.php. The previous logic parsed any host containing a slash, so existing configurations without a scheme will now fail to authenticate. Consider extracting the path whenever a slash is present, not only when a scheme is prefixed.
Useful? React with 👍 / 👎.
dudantas
changed the title
This pull request introduces multi-server configuration support and implements two-factor authentication (2FA) for login, along with improvements to account credential management and error handling. The most important changes are grouped below.
Multi-server configuration and management:
Servers_initconfiguration system ininit.lua, allowing clients to easily switch between multiple servers and worlds from a single installation. This includes anENABLE_SERVERSflag to enable/disable the entire configuration block and per-server settings such as port, protocol, and authentication options. (init.luainit.luaL12-R84)Two-factor authentication (2FA) integration:
authenticatortoken.otui), and added logic to prompt users for a token when required, including error handling for incorrect tokens. (authenticatortoken.otui[1]entergame.lua[2] [3] [4]meta.lua[1]entergame.lua[2] [3]Account credential management improvements:
ServerListmodule. The UI updates automatically based on stored credentials, and the "Remember Email" checkbox is now server-specific. (entergame.lua[1] [2] [3] [4] [5] [6]safeDecrypthelper to robustly handle decryption failures when loading credentials. (entergame.luamodules/client_entergame/entergame.luaR3-R7)UI and error handling enhancements:
entergame.lua[1] [2]entergame.lua[1] [2]Server list and autologin support:
entergame.lua[1] [2]