Skip to content

Conversation

@Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Oct 30, 2025

Description

Currently the wheel of destiny is not implemented.
The wheel packet is being sent on startup.
This breaks the communication for me on 13.20.
This commit fixes that problem by adding code that reads this packet.

Possible problem:
I am not sure when was "the way of the monk" added to the wheel of destiny packet.
I know that monk was added in 15.00, but at the time of figuring out the packet, I only had client 15.11 to test, so correct me if ">1500" is wrong in that version check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

I connected to a 13.20 server (tfs-based) with both regular client and otcr. The server has been online for over 3 years using the regular client so I am very certain of server side packet structure being correct.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

@javiertringol
Copy link

Those packets are considered in this PR #1398 , although the packets must be verified with all versions.
image

@Zbizu Zbizu marked this pull request as draft October 30, 2025 23:10
@Zbizu
Copy link
Contributor Author

Zbizu commented Oct 30, 2025

@javiertringol I wasn't aware of the other pr. I left my review there.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants