Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to Check the HTTP Response Text #80

Merged
merged 7 commits into from
May 14, 2022
Merged

Support to Check the HTTP Response Text #80

merged 7 commits into from
May 14, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented May 13, 2022 •
edited
Loading

This PR address the issue #76

simply copy the same feature from shell and ssh probe.

nullsimon
nullsimon reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@nullsimon nullsimon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this blank line

Screen Shot 2022-05-13 at 20 32 06

proditis
proditis reviewed May 13, 2022
View reviewed changes
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, these two minor suggestions can be ignored if you like (i'll address them at a later PR along with other documentation fixes)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
haoel and others added 2 commits May 14, 2022 06:52
@haoel @proditis
Update README.md
d133264 
Co-authored-by: Pantelis Roditis <proditis@users.noreply.github.com>
@haoel @proditis
Update README.md
06fff68 
Co-authored-by: Pantelis Roditis <proditis@users.noreply.github.com>
@zhao-kun zhao-kun merged commit 108daeb into megaease:main May 14, 2022
@haoel haoel deleted the http branch May 14, 2022 07:07
@haoel haoel mentioned this pull request May 15, 2022
Closed
@xcrossed xcrossed mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proditis proditis proditis left review comments

@nullsimon nullsimon nullsimon approved these changes

@zhao-kun zhao-kun zhao-kun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoel @proditis @zhao-kun @nullsimon