forked from codinguser/gnucash-android
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request codinguser#337 from fefe982/dev-migration
Remove static in DatabaseAdapter log tag. With static, different dbAdatpers will share one Log TAG. This will make the log message unclear. I saw some messages from AccountsDbAdapter mis-tagged as from ScheduledTransactionsDbAdapter. ROOT account's parents are assumed to be null. Setting ROOT account as its own parent will cause some infinite loops in the App. This caused an infinite loop in TransactionsActivity.onResume(), which may be related to the black screen problem. Auto-balancing transactions during import will loop through all transactions, this may cost a lot of time. This is rewritten as only select unbalanced transactions, and without constructing a Transaction instance, which saves a lot of time for book with a lot of transactions. Removed all references to dbAdapters and model objects from migration code. This change does not add functionality, may have less impact on speed. But as the code change is large, there may be some bugs introduced. I tested this with my large book, with some unbalanced transactions. It worked OK. But I never tested scheduled transactions.
- Loading branch information
Showing
3 changed files
with
162 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters