Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not existing function delete_index_source_task #333

Closed
kuhnchris opened this issue Feb 13, 2023 · 1 comment
Closed

Not existing function delete_index_source_task #333

kuhnchris opened this issue Feb 13, 2023 · 1 comment

Comments

@kuhnchris
Copy link
Contributor

kuhnchris commented Feb 13, 2023 •
edited
Loading

For some reason, index_source_task and check_source_directory_exists (signal.py) both reference a function delete_index_source_task which is nowhere to be found in the project - did you copy that from somewhere and forgot to put it in, or was that on the to-do list and never came around?
image

(Technically this edge case shouldn't exist, but... you know..)
@meeb
Copy link
Owner

meeb commented Feb 13, 2023

Ah, that did exist at one point, it doesn't now. It's such an edge case that it's extremely rare that it would get called so I guess it was unnoticed until now. These calls can just be removed.

kuhnchris added a commit to kuhnchris/tubesync that referenced this issue Feb 13, 2023
@kuhnchris
del delete_index_source_task calls - solves meeb#333
f4e5b6e
@kuhnchris kuhnchris mentioned this issue Feb 13, 2023
Merged
meeb added a commit that referenced this issue Feb 14, 2023
@meeb
Merge pull request #335 from kuhnchris/delete_index_source
f14d2dd 
del `delete_index_source_task` calls - solves #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuhnchris @meeb