chore(medusa, utils): rename buildLegacyFieldsListFrom to objectToStringPath #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 53193c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrien2p
approved these changes
Apr 5, 2023
|
don't forget the changeset |
olivermrbl
requested changes
Apr 5, 2023
| @@ -13,7 +13,7 @@ import { | |||
| queryEntityWithIds, | |||
| queryEntityWithoutRelations, | |||
| } from "../utils/repository" | |||
| import { buildLegacyFieldsListFrom } from "../utils" | |||
| import { objectToStringPath } from "../utils" | |||
There was a problem hiding this comment.
todo: Import from @medusajs/utils
| @@ -1,7 +1,7 @@ | |||
| import { flatten, groupBy, map, merge } from "lodash" | |||
| import { FindManyOptions, FindOptionsRelations, In } from "typeorm" | |||
| import { Order } from "../models" | |||
| import { buildLegacyFieldsListFrom } from "../utils" | |||
| import { objectToStringPath } from "../utils" | |||
There was a problem hiding this comment.
todo: Import from @medusajs/utils
| @@ -9,7 +9,7 @@ import { | |||
| import { ProductCategory } from "../models/product-category" | |||
| import { ExtendedFindConfig, QuerySelector } from "../types/common" | |||
| import { dataSource } from "../loaders/database" | |||
| import { buildLegacyFieldsListFrom } from "../utils" | |||
| import { objectToStringPath } from "../utils" | |||
There was a problem hiding this comment.
todo: Import from @medusajs/utils
| @@ -10,7 +10,7 @@ import { ExtendedFindConfig } from "../types/common" | |||
| import { dataSource } from "../loaders/database" | |||
| import { ProductFilterOptions } from "../types/product" | |||
| import { | |||
| buildLegacyFieldsListFrom, | |||
| objectToStringPath, | |||
There was a problem hiding this comment.
todo: Import from @medusajs/utils
| @@ -16,7 +16,7 @@ import { | |||
| } from "../models" | |||
| import { TaxRateListByConfig } from "../types/tax-rate" | |||
| import { isDefined } from "medusa-core-utils" | |||
| import { buildLegacyFieldsListFrom } from "../utils" | |||
| import { objectToStringPath } from "../utils" | |||
There was a problem hiding this comment.
todo: Import from @medusajs/utils
| @@ -153,7 +153,7 @@ function buildWhere<TWhereKeys extends object, TEntity>( | |||
| * output: ['test.test1', 'test.test2', 'test.test3.test4', 'test2'] | |||
| * @param input | |||
| */ | |||
| export function buildLegacyFieldsListFrom<TEntity>( | |||
| export function objectToStringPath<TEntity>( | |||
There was a problem hiding this comment.
suggestion: Keep this and deprecate it to stay backward compatible. And change all occurrences to import from @medusajs/utils
riqwan
force-pushed
the
chore/rename-function
branch
from
d86d60f to
c2914d5
Compare
riqwan
changed the title
This was referenced Apr 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVES CORE-1317