Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow-engine-inmemory): Fail trap for integration tests #11839

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adrien2p
Copy link
Member

What
Jest is patching the event emitter meaning that sometimes it can lead to flacky behaviors and block the test execution if the done callback is never reached. To prevent that from happening, the fail trap will call the done callback after a given time and warn that the test could not be concluded because of jest blocking it

Copy link

changeset-bot bot commented Mar 13, 2025

⚠️ No Changeset found

Latest commit: d77c446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 3:51pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
api-reference-v2 ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
docs-ui ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
docs-v2 ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
medusa-docs ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
resources-docs ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm
user-guide ⬜️ Ignored (Inspect) Mar 13, 2025 3:51pm

@adrien2p adrien2p marked this pull request as ready for review March 13, 2025 15:51
@adrien2p adrien2p requested a review from a team as a code owner March 13, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants