Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): add no_notification to shipment created event #11836

Merged
merged 2 commits into from
Mar 14, 2025
Merged

fix(core-flows): add no_notification to shipment created event #11836

merged 2 commits into from
Mar 14, 2025

Conversation

OttavioCas
Copy link
Contributor

What:

  • passes no notification toggle to shipment created event

Fixes #11505

@OttavioCas OttavioCas requested a review from a team as a code owner March 13, 2025 14:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e2e2a46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2025

@OttavioCas is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@OttavioCas OttavioCas changed the title add no_notification to shipment created event fix(core-flows): add no_notification to shipment created event Mar 13, 2025
@carlos-r-l-rodrigues
Copy link
Contributor

Thank you @OttavioCas

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 5e892e2 into medusajs:develop Mar 14, 2025
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification toggle on order fulfillment/shipping step
2 participants
@OttavioCas @carlos-r-l-rodrigues