Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip(core-flows, types): try payment cancelation if cart complete fails in the webhook #11832

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

wip(core-flows, types): try payment cancelation if cart complete fails in the webhook #11832

wants to merge 5 commits into from
+136 −25

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Mar 13, 2025

What

  • try cancel the payment if cart complete fails
  • reorder steps in the processPayment workflow

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 2:14pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 14, 2025 2:14pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm
user-guide ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 2:14pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1635092

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fPolic
fPolic commented Mar 13, 2025
View reviewed changes
packages/core/core-flows/src/payment/workflows/process-payment.ts
payment_id: paymentData.data?.[0]?.id,
},
})
.config({
Copy link
Contributor Author

@fPolic fPolic Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: should we allow this to throw now since it is a last step

@fPolic fPolic changed the title wip(core-flows): try payment cancelation if cart complete fails in the webhook wip(core-flows, types): try payment cancelation if cart complete fails in the webhook Mar 13, 2025
carlos-r-l-rodrigues
carlos-r-l-rodrigues reviewed Mar 13, 2025
View reviewed changes
packages/core/core-flows/src/cart/steps/compensate-payment-if-needed.ts Outdated
)

try {
await paymentModule.cancelPayment(payment.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this step specifically, does it make sense to check the status and either cancel or refund?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @carlos-r-l-rodrigues