feat(core-flows): revisit fulfillment flow reservations and support inventory kit #11790
+631
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 84b16a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 66 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fPolic
force-pushed
the
fix/ful-ikit-res
branch
from
689f4f6 to
9722c21
Compare
fPolic
changed the title
fPolic
requested review from
carlos-r-l-rodrigues
and removed request for
sgirones and
sradevski
olivermrbl
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Nice work @fPolic. No major comments, I'll let you decide if we merge now or after addressing the nits/suggestions.
| // find order item | ||
| const orderItem = order.items!.find((i) => i.id === lineItemId) | ||
| // find inventory items | ||
| const iitems = (orderItem as any)!.variant?.inventory_items |
There was a problem hiding this comment.
nit: I've seen (orderItem as any).variant a few times in this PR, would it make sense to update the type to reference it?
| @@ -199,6 +286,9 @@ export const cancelOrderFulfillmentWorkflow = createWorkflow( | |||
| "id", | |||
| "status", | |||
| "items.*", | |||
There was a problem hiding this comment.
question: Can we remote items.* in favor of specific properties?
| ).data.order | ||
| }) | ||
|
|
||
| it("should correctly manage reservations when canceling a fulfillment (with inventory kit)", async () => { |
There was a problem hiding this comment.
suggestion: This is great, but we could probably cover a few additional cases, e.g. the ones we expect to throw
olivermrbl
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
CLOSES CMRC-981