Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure shipment includes tracking numbers from fulfillment #11775

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: Ensure shipment includes tracking numbers from fulfillment #11775

wants to merge 4 commits into from

Conversation

ionutgaina
Copy link

@ionutgaina ionutgaina commented Mar 7, 2025 •
edited
Loading

What: Added existing tracking numbers during shipment creation from the admin dashboard

Bug details: See #11160

@ionutgaina ionutgaina requested a review from a team as a code owner March 7, 2025 21:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b026762

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 7, 2025

@ionutgaina is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

ionutgaina
ionutgaina commented Mar 7, 2025
View reviewed changes
...s/order-create-shipment/components/order-create-shipment-form/order-create-shipment-form.tsx
tracking_url: "#",
label_url: "#",
})),
labels: [...addedLabels, ...(fulfillment?.labels || [])],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combines labels added through the form (addedLabels) with existing labels from fulfillment, if available

...s/order-create-shipment/components/order-create-shipment-form/order-create-shipment-form.tsx
@@ -43,19 +43,21 @@ export function OrderCreateShipmentForm({
})

const handleSubmit = form.handleSubmit(async (data) => {
const addedLabels = data.labels
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just separated the logic from the createShipment function to improve readability

@ionutgaina ionutgaina changed the title Add support for existing tracking numbers in shipment creation [Bug]: Labels from createFulfillment() Are Overwritten When Marking as Shipped Mar 7, 2025
@ionutgaina ionutgaina changed the title [Bug]: Labels from createFulfillment() Are Overwritten When Marking as Shipped fix: Ensure shipment includes tracking numbers from fulfillment Mar 7, 2025
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fPolic
fPolic approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ionutgaina!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ionutgaina @fPolic @carlos-r-l-rodrigues