Skip to content

Improve PPO algorithm #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 9, 2021
Merged

Improve PPO algorithm #312

merged 12 commits into from
Jul 9, 2021

Conversation

isk03276
Copy link
Collaborator

@isk03276 isk03276 commented Jul 1, 2021

Improve PPO algorithm with continuous action.

  • Don't use clipped value loss
  • Use fixed logstd parameters to sample an action
  • Change backbone modules can be shared

[tested in lunarlander continuous v2]
W B Chart 7_1_2021, 5_25_50 PM

@isk03276 isk03276 requested review from jiseongHAN and darthegg and removed request for MrSyee July 1, 2021 08:27
@jinPrelude jinPrelude closed this Jul 1, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2021

This pull request introduces 1 alert when merging 8856de0 into 13f313b - view on LGTM.com

new alerts:

  • 1 for `__init__` method calls overridden method

@jinPrelude jinPrelude reopened this Jul 1, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 5, 2021

This pull request introduces 1 alert when merging d05cc0a into b3df31e - view on LGTM.com

new alerts:

  • 1 for `__init__` method calls overridden method

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2021

This pull request introduces 1 alert when merging 8cc7d05 into b3df31e - view on LGTM.com

new alerts:

  • 1 for `__init__` method calls overridden method

@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2021

This pull request introduces 1 alert when merging 1bf052d into b3df31e - view on LGTM.com

new alerts:

  • 1 for `__init__` method calls overridden method

@jinPrelude
Copy link
Collaborator

@all-contributors please add @isk03276 for code

@allcontributors
Copy link
Contributor

@jinPrelude

I've put up a pull request to add @isk03276! 🎉

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@jinPrelude jinPrelude merged commit 3d106e5 into master Jul 9, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request introduces 1 alert when merging c70ff3c into b3df31e - view on LGTM.com

new alerts:

  • 1 for `__init__` method calls overridden method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants