Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate distributed RL framework, Ape-X and Ape-X DQN #246

Merged
merged 30 commits into from
Jun 23, 2020

Conversation

cyoon1729
Copy link
Collaborator

@cyoon1729 cyoon1729 commented Jun 19, 2020

* Accept current change (master) for PongNoFrameskip-v4 dqn config
* Make env_info more explicit in run_pong script (accept incoming change)
* Make learner return cpu state_dict (accept incoming change)
Implement Logger and test wandb functionality
Add worker and logger render in argparse
Implement load_param() method in logger and worker
…__init__ for all ApeX actors

Implement test() in distributed architectures (load from checkpoint and run logger test())
* Move collect_data from worker class to ApeX Wrapper
* Change hyperparameters around
* Add worker-verbose as argparse flag
@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request introduces 1 alert when merging 4342b78 into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request introduces 1 alert when merging d36212a into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

* Add separate integration test for ApeX
* Add integration test flag to pong
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2020

This pull request introduces 1 alert when merging 1ab5e35 into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2020

This pull request introduces 1 alert when merging b954f4d into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2020

This pull request introduces 1 alert when merging a7be46b into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@cyoon1729 cyoon1729 changed the title Feature/add apex rebase Incorporate distributed RL framework, Ape-X and Ape-X DQN Jun 23, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request introduces 1 alert when merging 15bce10 into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request introduces 1 alert when merging ec150b5 into 815a1ca - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@cyoon1729
Copy link
Collaborator Author

apexresult
apexworker

Copy link
Collaborator Author

@cyoon1729 cyoon1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed new changes.

@MrSyee
Copy link
Collaborator

MrSyee commented Jun 23, 2020

#247 is solved.

@cyoon1729 cyoon1729 merged commit 9e897ad into master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants