-
Notifications
You must be signed in to change notification settings - Fork 46
feat(#383): Improvements to "Building App Forms" page #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#383): Improvements to "Building App Forms" page #1986
Conversation
mrjones-plip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thanks so much @jomcarvajal - this is really great feature and it just works to quickly copy content to either Google Sheets or LibreOffice.
I've made some inline suggestions that are pretty minor.
As well, could you add a note to the Style Guide on how to use this new table feature? This way folks in the future will have an easier time of seeing how to use it. I suggest looking at tabular schedules as an example
mrjones-plip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - thank your for making them.
I can't compile the site locally and CI is failing the same error I see:
Error: error building site: process: readAndProcessContent: "/home/runner/work/cht-docs/cht-docs/content/en/building/tutorials/app-forms.md:52:1": failed to extract shortcode: template for shortcode "copytable" not found
I think you maybe renamed some variable and forgot to commit it or something?
Once we fix this I think we'll be good to go!
Should be working now 👍 |
mrjones-plip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks again @jomcarvajal ! This has been merged to |

Description
Closes #383
Modifications:
The styles tried to mimic the page style. If the color, margin, background or anything else don't fit then let me know what options could be better.
Screenshots:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.