Skip to content

Conversation

louis030195
Copy link
Contributor

Pull Request Template

Description

This PR introduces support for logical AND (&&) and OR (, or ||) operators within selectors, enabling more flexible and precise element targeting. This functionality is implemented across the selector parsing logic and the Linux, macOS, and Windows accessibility engines for both find_element and find_elements operations.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other:

Video Demo (Recommended)

🎥 Please include a video demo showing your changes in action! We might use it to post on social media and grow the community.

Suggested editing tools:

AI Review & Code Quality

  • I asked AI to critique my PR and incorporated feedback
  • I formatted my code properly
  • I tested my changes locally

Checklist

  • Code follows project style guidelines
  • Added video demo (recommended)
  • Updated documentation if needed

Additional Notes

  • The previous role|name selector syntax is now considered invalid. Please use role:X && name:Y for combining role and name conditions.
  • Clippy was skipped due to upstream compilation issues in the environment.

Open in Cursor Open in Web

Adds support for combining selectors using AND (&&) and OR (,) operators.

Co-authored-by: louis.beaumont <louis.beaumont@gmail.com>
Copy link

cursor bot commented Sep 9, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@louis030195 louis030195 marked this pull request as ready for review September 9, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants