This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Feature/karma sourcemap fix #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2016 09:33
Don't use the newest awesome-typescript-loader for now as it contains a breaking change. Set version 2.0.1 until the issue is resolved.
Remove karma-source-map-support dependency, it is no longer needed. The karma-sourcemap-loader module will handle source maps for us. Add the sourcemap preprocessor to the test files as well so the test file line numbers also match. Instead of the devtool option in the webpack test config, use the SourceMapDevToolPlugin. This will also generate source maps on files with a .ts extension. Fixes #15
|
LGTM, only the sourcemaps to the TS source on errors during tests are not pointing to the correct line number. Both for runtime errors as for assert errors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove karma-source-map-support dependency, it is no longer needed. The karma-sourcemap-loader module will handle source maps for us.
Add the sourcemap preprocessor to the test files as well so the test file line numbers also match.
Instead of the devtool option in the webpack test config, use the SourceMapDevToolPlugin. This will also generate source maps on files with a .ts extension.
Fixes #15