This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move karma.conf.js to root of repo #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the karma.conf.js configuration file to the root of the repository, for better karma support in Webstorm. Webstorm can't currently handle karma configuration in a subfolder well.
| @@ -10,7 +10,7 @@ | |||
| "typings": "typings install", | |||
| "test": "npm run validate", | |||
| "validate": "npm-run-all -p validate-webpack lint test-unit -s check-coverage", | |||
| "test-unit": "karma start config/karma.conf.js --single-run --browsers PhantomJS", | |||
| "test-unit": "karma start karma.conf.js --single-run --browsers PhantomJS", | |||
There was a problem hiding this comment.
I think we can leave the reference to karma.conf.js out here, as it's picked up by default (just like the tsconfig.json in the tsc).
The karma.conf.js no longer needs a reference in the npm test-unit script, because it is in the default location.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the karma.conf.js configuration file to the root of the repository, for better karma support in Webstorm. Webstorm can't currently handle karma configuration in a subfolder well.