Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/73 add quality option for optimizing images #74

Conversation

mm-paulie
Copy link
Collaborator

@mm-paulie mm-paulie commented Aug 9, 2023

If you add lowestImageQuality to your settings in the .sharedrc config and describe a quality percentage (default is 60) you can set the quality of the image compression lower or higher, example:

  "settings": {
    "browserSupport": [
      "> 1%",
      "not ie 11"
    ],
    "maxFileSize": 20,
    "optimizeToFileSize": true,
    "lowestImageQuality": 20
}

For testing:

  • checkout mediamonks/display-dev-server
  • switch to my for and then to this feature branch
  • in this branch, type npm link and npm install
  • create a new banner, by running yo display-boilerplate and npm install
  • then type your newly created setup folder: npm link path-to-feature-branch ie npm C:\Users\paulie\git\m\mediamonks\da-framework\display-dev-server
  • if all has been tested, in your display-dev-server folder, type npm unlink to get back your original display-dev-server rather than my forked one :)

…ePlugin

If you add lowestImageQuality to your settings and describe a quality percentage (default is 60) you can set the quality of the image compression lower or higher
…-for-optimizing-images' into feature/73-add-quality-option-for-optimizing-images
Copy link
Collaborator

@mm-vasyl mm-vasyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@Syridiana
Copy link

Awesome ! Works on my end

@mm-paulie mm-paulie merged commit 4024a7c into mediamonks:master Aug 15, 2023
@xaviergdiez84
Copy link
Collaborator

Works here as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants