Fixes a crash if document.body is not ready yet #144
Conversation
jantimon
changed the title
|
Nice catch, thank you! I guess "accessing document.body too soon" happens when you synchronously load ally.js in |
|
Correct - during dev we bundle it and the result is placed in the head (because of some other dev tools). |
|
Cool thanks 👍 will there be a 1.1.1? |
|
Nope, but there will be a "dependencies": {
"ally.js": "https://s3.eu-central-1.amazonaws.com/ally.js/travis/565/ally.js.tar.gz",
} |
|
I guess my teammates won't understand which version https://s3.eu-central-1.amazonaws.com/ally.js/travis/565/ally.js.tar.gz is ;) Maybe I gonna use the github repository of the fork like: Is there any reason why ally.js is not following semantic versioning? |
That won't contain the UMD build, as well as the AMD and CommonJS modules. If you're using the ES6 source modules, this is an option. I'd recommend going with the artifact I've linked to, as that's exactly what you'd get from npm (except for the version described in package.json).
semver defines what kind of version bump is appropriate for what kind of change. As far as I know it does not, however, mandate that a change must be released right away. The pre-release version notation is in line with semver. I don't think "ally.js is not following semantic versioning" is a correct assessment. The release process is manual, as I have not yet gotten around to automatic/continuous releases. Also I have other things I'm still working on (albeit not at the speed I'd like to). Are you're interested in helping out with this? |
|
Sure - what can I do to help you with it? |
|
Do you know https://github.com/semantic-release/semantic-release ? It will create a release for every master commit (so it requires squashing commits during merging). |
|
I know of semantic-release, but I haven't tried to integrate it yet. Mainly because I think my commit messages are not 100% compatible… |
|
Oh that's configurable. |
|
Your fix is included in v1.1.1 released just now. |
|
Thank you so much! 👍 |
Ally tries to access
document.bodyto soon.This fix uses
document.documentElementwhich is the "html" element.