Add Magento projects to project type mapping #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to install the testing suite for Magento, it's now possible to set the project type in the project's composer.json file to `magento2-project` or `magento-project` to get the correct coding standards files in the project.
leonhelmus
approved these changes
Mar 24, 2021
|
Looks good i have also tested it. Just waiting for an approval of @marcelmediact . |
marcelmediact
requested review from
ksangers
and removed request for
marcelmediact
ksangers
suggested changes
Mar 25, 2021
|
@ArjenMiedema I'm afraid I have a small request for change. To prevent it from being removed in the future. |
added 3 commits
March 25, 2021 14:04
To make it easier to install the testing suite for Magento, it's now possible to set the project type in the project's composer.json file to `magento2-project` or `magento-project` to get the correct coding standards files in the project.
…on-type-field-composer-json * upstream/master: Add Alumio support Implement PHP Lint checks
…omposer-json' into 62-base-template-on-type-field-composer-json * origin/62-base-template-on-type-field-composer-json: Add Magento projects to project type mapping
ksangers
approved these changes
Mar 25, 2021
ArjenMiedema
pushed a commit
to ArjenMiedema/testing-suite
that referenced
this pull request
Mar 26, 2021
…-coding-standards * upstream/master: Add Magento projects to project type mapping (mediact#66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to install the testing suite for Magento, it's
now possible to set the project type in the project's composer.json
file to
magento2-projectormagento-projectto get the correctcoding standards files in the project.