Add attachment management functionality #1423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@mgogoulos, Do i need to add you as reviewer after i'm done? If yes, how? |
# Conflicts: # files/frontend_translations/ar.py # files/frontend_translations/bn.py # files/frontend_translations/da.py # files/frontend_translations/de.py # files/frontend_translations/el.py # files/frontend_translations/en.py # files/frontend_translations/es.py # files/frontend_translations/fr.py # files/frontend_translations/he.py # files/frontend_translations/hi.py # files/frontend_translations/id.py # files/frontend_translations/it.py # files/frontend_translations/ja.py # files/frontend_translations/ko.py # files/frontend_translations/nl.py # files/frontend_translations/pt.py # files/frontend_translations/ru.py # files/frontend_translations/sl.py # files/frontend_translations/tr.py # files/frontend_translations/ur.py # files/frontend_translations/zh_hans.py # frontend/yarn.lock # static/css/media.css # static/js/_commons.js # static/js/categories.js # static/js/embed.js # static/js/featured.js # static/js/history.js # static/js/index.js # static/js/latest.js # static/js/liked.js # static/js/manage-comments.js # static/js/media.js # static/js/members.js # static/js/profile-about.js # static/js/profile-media.js # static/js/profile-playlists.js # static/js/recommended.js # static/js/search.js # static/js/tags.js
Contributor
|
Hi @christophe195 , thanks for submitting this PR. This looks good. One thing I'd like to mention is that this is a very custom feature, so we don't want to have it there by default for all use cases. Usually we make a configuration for this type of features, that is disabled by default, but you can easily enable it through the setting. Eg that could be a setting ATTACHMENTS_FUNCTIONALITY (or something better!) that is False by default and this check takes place in all areas where a user can see this (like the media page, or the edit media tab) but also in the code. Hope this makes sense! |
Author
|
Sure, will do. |
christophe195
force-pushed
the
feature/add_attachments
branch
2 times, most recently
from
7404ebf to
a52bf22
Compare
Author
|
@mgogoulos , option is added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first public PR.
Description
This PR adds the ability to add attachments to a video.
After uploading, you will find an “attachment” button in the navigation bar when managing the video. Here you can add attachments, name them, and delete them.
Once you have done this, a button will appear next to Download for the attachments.
Please be sure to check the code in terms of security; I am not very familiar with the project.
I did use AI for the translations