Skip to content
This repository was archived by the owner on Dec 14, 2023. It is now read-only.

[RFR] remove crimson hexagon references#793

Merged
pypt merged 3 commits into
masterfrom
jot-delete-chexagon
Jul 12, 2021
Merged

[RFR] remove crimson hexagon references#793
pypt merged 3 commits into
masterfrom
jot-delete-chexagon

Conversation

@jtotoole

@jtotoole jtotoole commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Decided to make a fresh PR rather than fight my way out of merge commit hell on #785.

Does adding select insert_platform_source_pair( 'twitter', 'brandwatch' ); here in mediawords.sql entail a migration, and should I also delete select insert_platform_source_pair( 'twitter', 'crimson_hexagon' );?

@jtotoole jtotoole requested a review from pypt June 23, 2021 00:29
@jtotoole jtotoole changed the title remove crimson hexagon references [WIP] remove crimson hexagon references Jun 23, 2021
@jtotoole jtotoole changed the title [WIP] remove crimson hexagon references [RFR] remove crimson hexagon references Jul 1, 2021
@jtotoole

jtotoole commented Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

@pypt now we're in business (RFR = Ready For Review).

assert _get_feed_url_from_google_podcasts_url('http://www.example.com/') == 'http://www.example.com/'
assert _get_feed_url_from_google_podcasts_url('totally not an URL') == 'totally not an URL'

npr_feed_url = 'https://feeds.npr.org/381444908/podcast.xml'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feed url seems to oscillate at times for no reason, so hopefully the FT one will be more stable

@pypt

pypt commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Does adding select insert_platform_source_pair( 'twitter', 'brandwatch' ); here in mediawords.sql entail a migration, and should I also delete select insert_platform_source_pair( 'twitter', 'crimson_hexagon' );?

I think it does - that function preloads the table with some platform-source pairs, so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair.

@pypt

pypt commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

I think it does - that function preloads the table with some platform-source pairs, so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair.

...and all of the rows in other tables with reference that particular row in topic_sources.

@jtotoole

jtotoole commented Jul 2, 2021

Copy link
Copy Markdown
Contributor Author

...so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair

Would it be okay to do that in a separate PR once the pgmigrate one gets merged?

@pypt pypt merged commit 4bd46ad into master Jul 12, 2021
@pypt

pypt commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

Very cool, thank you! Down with CH!

@pypt pypt deleted the jot-delete-chexagon branch July 12, 2021 21:23
@pypt

pypt commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

Would it be okay to do that in a separate PR once the pgmigrate one gets merged?

Sure, moved this to #798,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants