refactor(helper/css): fix nonce feature #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
meck93
approved these changes
Nov 23, 2024
| @@ -103,7 +103,7 @@ export const createCssContext = ({ id }: { id: Readonly<string> }): DefaultConte | |||
| } | |||
|
|
|||
| const addClassNameToContext: HtmlEscapedCallback = ({ context }) => { | |||
| if (!contextMap.get(context)) { | |||
| if (!contextMap.has(context)) { | |||
| @@ -62,8 +62,9 @@ export const createCssContext = ({ id }: { id: Readonly<string> }): DefaultConte | |||
| const [cssJsxDomObject, StyleRenderToDom] = createCssJsxDomObjects({ id }) | |||
|
|
|||
| const contextMap: WeakMap<object, usedClassNameData> = new WeakMap() | |||
| const nonceMap: WeakMap<object, string | undefined> = new WeakMap() | |||
There was a problem hiding this comment.
This is a lot cleaner. I like it. Thanks for the feedback and the idea 👍
meck93
merged commit 45ce947
into
meck93:feature/add-CSP-nonce-to-CSS-related-style-and-script-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code