fix the example code in README.md #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philipodev is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Thanks @philipodev! Agree that making them optional would be better, but this is still accurate. Feel free to open another PR to make the underlying types optional and undo the data defaulting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a great project!
Had some minor issues with the example code in README but i figured them out.
The example is lacking the
contentandrootproperties in theinitialData. (so i get a TypeError for trying to read title of undefined root).Also added the neccessary css import.
A better fix would probably be to make them optional instead of just empty objects. Happy to close this one and work on that instead if you feel like that would be a more preferable fix.
Cheers!