-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new drag-and-drop engine #598
base: main
Are you sure you want to change the base?
Conversation
…opContext component
…anges result in UI changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
setDragAxis("dynamic"); | ||
} else { | ||
setDragAxis("y"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work if the item is dragged between dropzones with drag axes?
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
Works on mobile and doesn't conflict with dnd-kit setPointerCapture bugfix, which is necessary to ensure reparenting on mobile devices don't break pointer tracking.
@chrisvxd This sounds very exciting. Dnd kit will really be a good upgrade. May I know, if there are any estimates of when this will be ready to use. Both stable and beta version of it. |
Also catches an edge-case where ref is the same
The drag would start before draggedItem existed, making it possible to drag an item into a disallowed DropZone.
Thanks @princebansal - we don't have a timeline yet. It's slow progress as it's a non-trivial implementation. I would like to get it out by end of October in v0.17, but that's not based on anything! |
…roppableTarget isDroppableTarget stopped working in 4c7c915.
data: { | ||
direction: interval.direction, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires upstream changes.
Implement new drag-and-drop engine using the experimental dnd-kit release.
This is a work-in-progress. Commits and code will be tidied up before finalising. It relies on upstream changes to dnd-kit (which have not yet been pushed anywhere).
Features
Still to do