feat: expose setHistories and setHistoryIndex #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mkilpatrick is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
requested changes
Jul 16, 2024
Co-authored-by: Chris Villa <chrisvxd@users.noreply.github.com>
Co-authored-by: Chris Villa <chrisvxd@users.noreply.github.com>
Co-authored-by: Chris Villa <chrisvxd@users.noreply.github.com>
chrisvxd
approved these changes
Jul 23, 2024
| act(() => renderedHook.result.current.record("Oranges")); | ||
| act(() => renderedHook.result.current.setHistoryIndex(0)); | ||
|
|
||
| expect(renderedHook.result.current.hasPast).toBe(true); |
There was a problem hiding this comment.
I'm trying to full remember the functionality of hasPast.
This test (and some of the ones I wrote) read to me like hasPast should be false when you're at index 0, but they're all asserting it to be true.
This is nothing wrong with your tests, but just making a note for myself to think about.
There was a problem hiding this comment.
-1 is the no history index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #519.
This change exposes the history store's setHistories and setHistoryIndex functions. When they are called the data is dispatched so that Puck rerenders. The use case this supports is when a Puck consumer wants to change or reset the history state manually without requiring the page to be refreshed.