Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Conversation

@simison
Copy link
Contributor

@simison simison commented Jul 29, 2015

Using Grunt's internal mkdir().

It creates the folder only if it doesn't exist already.

Alternative solution for #584

@ilanbiala
Copy link
Member

@lirantal LGTY?

@ilanbiala ilanbiala self-assigned this Jul 29, 2015
@ilanbiala ilanbiala added this to the 0.4.0 milestone Jul 29, 2015
@lirantal
Copy link
Member

We just need one more thing before we merge - please add that uploads directory /modules/users/client/img/profile/uploads to .gitignore so that users don't accidentally push binary data to repositories/PRs.

Other than that looks good, thanks @simison

@simison
Copy link
Contributor Author

simison commented Jul 29, 2015

@lirantal it's there already: https://github.com/meanjs/mean/blob/0.4.0/.gitignore#L23

I was a bit confused about ./uploads/ directory appearing there as well, but that comes from some multipart middleware stuff. That "uploads" is in .gitignore as well, so it effectively ignores any "uploads" directory/file anywhere at the folder structure. Making that "uploads/" instead would fix it but this is a bit of bikeshedding already...

@lirantal
Copy link
Member

Great, so we're good here.

@lirantal lirantal mentioned this pull request Jul 29, 2015
14 tasks
ilanbiala added a commit that referenced this pull request Jul 29, 2015
Add Grunt task to make sure uploads directory exists
@ilanbiala ilanbiala merged commit b7aebf3 into meanjs:0.4.0 Jul 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants