Move Logo, Favicon, and Livereload to Config #664
Conversation
|
thanks @codydaig |
config/env/default.js
Outdated
There was a problem hiding this comment.
why is one file relative and the other absolute? I know that you just took the value and put it in the config, but should this be switched to a relative path? Templates follow relative paths.
There was a problem hiding this comment.
I copied and pasted the values. I'm not opposed to one over the other.
There was a problem hiding this comment.
@rhutchison Is there a specific change you want me to make?
There was a problem hiding this comment.
@codydaig I know you just moved the value, but I think the project has been following mainly relative paths. Can you change to relative and test?
|
@rhutchison @codydaig Ping me when you guys work it out to review and merge. |
# The first commit's message is: Config for Logo, Favicon, and Livereload # This is the 2nd commit message: Moved livereload config outside of app # This is the 3rd commit message: Make Favicon relative
Moved livereload config outside of app
|
DO NOT MERGE! I messed up. I'll fix it after my next meeting. |
|
See #685 (this branch on my end is having git issues) |
|
Okie dokie |
3 participants
In reference to #536 from @hawmen I moved the logo, favicon, and live reload options to the configuration files.