Update provider data

[sielay]

It address issue 228, when provider data are not updated (including tokens).

It still not support path for "not logged in yet".

[sielay]

Please wait for that one. I have found one other place in the flow, that doesn't work perfectly with such update. user.authentication.server.controller.js line 89 assume you are not logged in. Will update, retest and update Pull Request. In general your flow need bit review here, as it's thinking mostly about first bind with oauth provider, not much about future updates and token refreshes.

[sielay]

Found one missing return in my code. Retested, checked in all flows, committed and squashed. Hope it will work for you, for me works :)

[rschwabco]

@NeverOddOrEven - Can you take a look at this?

[NeverOddOrEven]

I'll definitely take a look, but it may be Friday before I get a real chance to comprehend what's going on fully.

[NeverOddOrEven]

lgtm. sorry for the delay, I have been away from my laptop

[ilanbiala]

@NeverOddOrEven @roieki maybe we should hold off on this until we decide how users will be dealt with? The additionalProvidersData field might not be used anymore, and this might require some serious refactoring then.

[sielay]

@ilanbiala you can ignore it, PR I made for user refactor involves that scenario already

[NeverOddOrEven]

Original Issue: #288
Discussion: #337
PR: #343

Closing this, and referencing from the PR. Resume conversation there please.