This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
test(travis): Add Testing for Node 5 #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilanbiala I'm not opposed. |
|
LGTM, we can merge now too because failures won't break anything. |
ilanbiala
added a commit
that referenced
this pull request
Nov 1, 2015
test(travis): Add Node 5 testing to Travis CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Node 5 to the
.travis.yml, but allowed failures. Since Node v5 uses npm 3 there's some work to be done to support it.Since the build is currently failing on Node 5, I added a note to the README under the prerequisites to make clear that Node 5 is not supported at this time.