0.4 - favicon link in layout.server.view.html

[mg1075]

I believe the link for the favicon needs to be changed in the core module, because the link is missing a reference to the client folder.

current:
<link href="/modules/core/img/brand/favicon.ico" rel="shortcut icon" type="image/x-icon">

change to:
<link href="/modules/core/client/img/brand/favicon.ico" rel="shortcut icon" type="image/x-icon">

[mg1075]

I guess the question really is: why should config/lib/express.js be taking out '/client'? What is the rationale for this?

/**
 * Configure the modules static routes
 */
module.exports.initModulesClientRoutes = function (app) {
    // Setting the app router and static folder
    app.use('/', express.static(path.resolve('./public')));

    // Globbing static routing
    config.folders.client.forEach(function (staticPath) {
        app.use(staticPath.replace('/client', ''), express.static(path.resolve('./' + staticPath)));
    });
};

[lirantal]

@mg1075 I'm not sure why is that.
What's else in /client? can you investigate and shed more light there?

[pgrodrigues]

0.4.0 is using serve-favicon middleware in config/lib/express.js which indeed has the correct path to the favicon:

// Initialize favicon middleware
app.use(favicon('./modules/core/client/img/brand/favicon.ico'));

and will intercept any GET /favicon.ico.

[rhutchison]

Close?

[lirantal]

before we close we should still confirm if this is some bug or not.
@pgrodrigues @mg1075 can you confirm if it's working as expected?

[mg1075]

Fine to close.

The issue here that is kind of awkward from my perspective is how layout.server.view.html has its file paths altered. Another example is:
<div ng-include="'/modules/core/views/header.client.view.html'"></div>

The real folder path is modules/core/client/views/header.client.view.html, but again this path gets modified on the server. To people looking at the view the first time, this is not going to be immediately obvious.

[pgrodrigues]

Both the favicon and the ng-include work but maybe the paths weren't updated from 0.3.0 to 0.4.0. 0.3.0 seems to have the same paths as 0.4.0 despite the directory structure being different.

[codydaig]

I'll make note to add this to the documentation. #443

[kimgeorge83]

I'm not sure I understand why the /client is removed from the paths. It's not very intuitive. Could someone explain the rationale? I spent a long time trying to figure out why my paths weren't being found, I asked the question on stack exchange (http://stackoverflow.com/questions/31491925/angular-js-directive-templateurl-not-found-on-mean-js-stack/31508318#31508318).

[codydaig]

This seems to be a common issue. I'm not sure why it removes the /client from the paths but you could change it in the config file if you want it back in on your project.

[kimgeorge83]

No worries, I'll try changing it on my project, I'm just a bit worried I might break something. I'd really like to understand the rationale why this was done.

[mg1075]

Doesn't the modification of the file path defeat the goal of quickly identifying files and destinations? I think it is better to have verbose path names rather than slightly less verbose path names that have their paths dynamically - and in a kind of sneaky way - altered. Again, it would be really helpful to know the thinking that went behind this design decision.

[kimgeorge83]

@amoshaviv, it looks like you originally added the module static routes section in express.js, are you able to comment on the rationale for removing /client form the static paths? We are just trying to determine if we'll break anything by removing it on our projects.

[kimgeorge83]

I modified the /client removal behavior and it doesn't seem to affect the site behavior. I'll let you know if I run into any issues. I updated the post here with details of the fix (http://stackoverflow.com/questions/31491925/angular-js-directive-templateurl-not-found-on-mean-js-stack/31508318#31508318).

I can make the change to mean.js if people are interested but the yeoman module generator will also need to be modified since it generates modules with the paths missing the /client

[lirantal]

@kimgeorge83 so I'm not sure if you are referring to an actual bug here or just question about convention.

@rhutchison @trainerbill do you have an idea how/if the /client affects anything?