Page not found handler not working in 0.4.0

[debrouxl]

Steps to reproduce:

• clone the repository;
• run npm install;
• run grunt;
• load an URL for which there's no route, e.g. http://localhost:3000/abcdefghijklmnopqrstuvwxyz (why not ;) )

Expected result:

• a 404 status code and a redirection to http://localhost:3000/not-found , displaying an error message.

Actual result:

• a 200 status code and a redirection to http://localhost:3000 , effectively displaying the root page.

If I remove the "*" from the last route of modules/core/server/routes/core.server.routes.js, the 404 functionality is restored; however, sign up, sign in and pretty much everything else is broken, because of the fallback to the error routes defined in config/lib/express.js. I haven't yet found what the correct fix is.

I noticed the issue on my own testing application, when the server not only produced a 200 status code, but also the HTML content of the root page, when requested an image which wasn't there.

[dotch]

Since we are using html5-mode routes, angular is responsible for showing 404 pages for most routes, right?
so I guess we should handle the server side 404s like this:

// Return a 404 for all undefined api, module or lib routes
app.route('/:url(api|modules|lib)/*').get(core.renderNotFound); 

and either keep the redirect for everything else or implement angular based 404 logic as well.

[lirantal]

I assume we can close this now that we merged #566 ?