fix: Remove API Tokens from User APIs #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
approved these changes
Jan 29, 2025
|
FWIW I would not have reported if it was only names 👍 so this works for me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
Removes tokens from all APIs other than the create API (since you need the token exactly once, upon creation).
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4981
Special notes for your reviewer:
(fill-in or delete this section)
The API still returns a list of all user tokens to the admin due to how our models are set up. We should probably stop doing this, but now that the actual token string isn't being returned it's not a security risk (and it's restricted to admins). Removing the tokens from this API will take some more effort/investigation since that endpoint is used in several places in the app.
Testing
(fill-in or delete this section)
Tested the frontend locally (to make sure you can still copy the token, etc.) and added backend tests to assert that the token is private.