fix: Fixed LastMade recipes sorting order

[PancakeZik]

What this PR does / why we need it:

Fixes postgres incorrectly sorting null as the most recent.

-->

Which issue(s) this PR fixes:

Fixes #4937

Special notes for your reviewer:

The original problem was only reproduced in postgres - in sqlite it was fine.

Testing

Ran checks

[michael-genson]

I don't think we want to bake this into the repository on the backend. The backend already supports specifying null ordering. Can we make this change to the frontend query instead?

From the API docs:

[PancakeZik]

With my limited knowledge I couldnt find a way to make it work on the front end, but I will experiment with what you showed in the screenshot.

…

On Wed, 29 Jan 2025, 17:46 Michael Genson, ***@***.***> wrote: ***@***.**** requested changes on this pull request. I don't think we want to bake this into the repository on the backend. The backend already supports specifying null ordering <https://docs.mealie.io/documentation/getting-started/api-usage/#order-by>. Can we make this change to the frontend query instead? From the API docs: image.png (view on web) <https://github.com/user-attachments/assets/df37bf49-c666-4880-a2a7-a94e32a34316> — Reply to this email directly, view it on GitHub <#4980 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4662Q2KBXZK5CHQSG5DED2NEHYFAVCNFSM6AAAAABWDARUAWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBRG44TGMZWHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[michael-genson]

You can probably add some logic here that handles null sorting:

mealie/frontend/components/Domain/Recipe/RecipeCardSection.vue

Lines 238 to 248 in 4229061

	async function fetchRecipes(pageCount = 1) {
	return await fetchMore(
	page.value,
	perPage * pageCount,
	props.query?.orderBy || preferences.value.orderBy,
	props.query?.orderDirection || preferences.value.orderDirection,
	props.query,
	// we use a computed queryFilter to filter out recipes that have a null value for the property we're sorting by
	queryFilter.value
	);
	}

You can calculate the order by null, something like:

const orderDir = props.query?.orderDirection || preferences.value.orderDirection;
const orderByNull = orderDir === "asc" ? "first" : "last"

Then pass orderDir and orderByNull to fetchMore. You will also have to modify fetchMore to accept null ordering (see the API docs)

[PancakeZik]

See what you think now?

[michael-genson]

Looks good! Just a couple small code cleanliness things

[michael-genson]

Looks great now, thanks for this! I think since I pushed the last bit someone else will have to approve it, but putting my approval here anyway for visibility