feat: Move "on hand" and "last made" to household #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relationships-to-households
…relationships-to-households
|
Merged this with main now that the cocktail builder is in and updated the logic as needed |
…relationships-to-households
michael-genson
commented
Jan 8, 2025
| @@ -22,7 +22,6 @@ | |||
| } | |||
| resetDialog(); | |||
| " | |||
| :submit-disabled="isCreateDisabled" | |||
There was a problem hiding this comment.
This was duplicated above somehow
Kuchenpirat
previously approved these changes
Jan 13, 2025
|
welp should have merged the ruff stuff afterwards. |
…relationships-to-households
|
All good, it probably would've messed the ruff PR up anyway |
Kuchenpirat
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This feature migrates food on-hand and tool on-hand to be configured per-household, as well as the recipe's "last made" property. The user experience is mostly the same,
(this plays nicely with the cocktail builder PR, although it may generate some merge conflicts)fixed now that it's merged.While working on this PR I also uncovered/fixed a few existing issues:
orderByparam must be in snake case, while filters can be in either snake case or camel case. This PR fixes this by allowing camel case in the order byWhich issue(s) this PR fixes:
(REQUIRED)
N/A
Special notes for your reviewer:
(fill-in or delete this section)
If this is merged before the cocktail builder, I will update that PR to use the new on hand properties. If the cocktail is merged before this, I will fix it in this PRfixed.Testing
(fill-in or delete this section)
Pulled up two browsers with users from different households, as well as a bunch of backend tests.