feat: Additional Household Permissions #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
reviewed
Sep 17, 2024
frontend/components/Domain/Recipe/RecipePage/RecipePageParts/RecipePageHeader.vue
Outdated
Show resolved
Hide resolved
…ecipePageHeader.vue Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
…nal-household-permissions
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
Choromanski
pushed a commit
to Choromanski/mealie
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR adds two household-related permissions:
Lock Recipe Edits From Other Households
This flag lets households decide if other households can only view their recipes, or if they can edit them. With this unflagged, any user from any household in the group can edit their recipes.
When set, it behaves like it was implemented in #4089 (users from other households can't edit). When unset, edits (including deletes) are allowed (this is a new feature from this PR).
Can Manage Household
This flag allows users to manage household settings (such as the new lock recipe edits flag). Previously this was tied to the generic
Can Managepermission, but it makes sense to want users to be able to manage their own households, but not necessarily manage the group.Both flags are added to their respective settings pages:
I also merged the two household settings pages; one was using a component, and one was just baked into the page, so I replaced the page one with the component. The component was missing all of the help text, so I re-wrote it to support the help text.
For reference, it currently looks like this:
And now it looks like this:
Which issue(s) this PR fixes:
(REQUIRED)
Closes #4082
Special notes for your reviewer:
(fill-in or delete this section)
I added a new route to fetch a household by id, since we need to check permissions of the recipe's household (which isn't always your household anymore). I also fixed the inconsistency where getting a recipe by id works, but updating/deleting only works by slug. All recipe routes should accept either slugs or ids now.
Testing
(fill-in or delete this section)
frontend and backend tests