fix: Offline Shopping List Fixes #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
approved these changes
Jul 2, 2024
|
FYI @bartkummel, this will hopefully address the issues you raised the other day. |
boc-the-git
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 53c89b3.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
There were some issues reported after #3760 was merged. Without logs I can't confirm if the exact issues were addressed, but this PR does address things related to the reported issues. Namely it broadens the network error detection and checks whether the queue is out of sync more frequently.
Which issue(s) this PR fixes:
(REQUIRED)
N/A, discussed on #3760
Testing
(fill-in or delete this section)
Local testing