feat: Add the ability to flag a food as "on hand", to exclude from shopping list #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
commented
Jun 23, 2024
boc-the-git
commented
Jun 23, 2024
| @@ -144,12 +146,15 @@ class IngredientFoodModel(SqlAlchemyBase, BaseMixins): | |||
| name: Mapped[str | None] = mapped_column(String) | |||
| plural_name: Mapped[str | None] = mapped_column(String) | |||
| description: Mapped[str | None] = mapped_column(String) | |||
| on_hand: Mapped[bool] = mapped_column(Boolean) | |||
There was a problem hiding this comment.
This is the only actual functional change in this file
boc-the-git
commented
Jun 23, 2024
| @@ -36,6 +36,7 @@ class UnitFoodBase(MealieModel): | |||
| plural_name: str | None = None | |||
| description: str = "" | |||
| extras: dict | None = {} | |||
| on_hand: bool = False | |||
There was a problem hiding this comment.
This is the only actual functional change in this file
|
LGTM, besides the one comment I had. Once this is ready I'll pull it locally and test it out, but reviewing the dif looks good |
michael-genson
requested changes
Jun 27, 2024
|
Changes made @michael-genson; good suggestions!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds the ability to mark a food as "on hand" (terminology taken from tools). Then when adding a recipe to a shopping list, on hand foods will be unticked by default. Current behaviour is that every ingredient is ticked by default. The intent is to use this for your staple ingredients that you rarely need to buy, sugar, salt, spices, rice, ...
Don't ask me how this recipe would turn out!! 🙈
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
I think the change is fairly straight forward. There are a couple files that had a lot of formatting updates applied, so I've put some comments to indicate the small change actually made in there.
Testing
Locally, with SQLite.