fix: Security Issues #3530
Merged
fix: Security Issues #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
previously approved these changes
Apr 30, 2024
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
boc-the-git
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Fixes some of the reported security issues from #3509
Which issue(s) this PR fixes:
(REQUIRED)
Partial #3509
Special notes for your reviewer:
This covers 2 and 3. More info in Discord.
Testing
(fill-in or delete this section)
Manually tested the logout, and manually checked the only frontend endpoint that uses group pagination. I also tested updating the group through the UI to confirm users aren't affected.