Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: frontend testing setup #1739

Merged
merged 18 commits into from
Oct 22, 2022
Merged

Conversation

hay-kot
Copy link
Collaborator

@hay-kot hay-kot commented Oct 18, 2022

What type of PR is this?

  • chore

What this PR does / why we need it:

Currently there is no testing framework enabled for the frontend. This PR sets-up the basic implementation for unit testing. I have yet to figure out how to implement component mounting and testing the actual Vue Components, but I think this is going to be merged as is, and we can add component testing later on.

Additionally, I've moved some of the isolated modules to a new lib folder. This is a pattern I've adopted in a few other projects that provide a place to put some utility type packages but still provide a clear namespace and location. It also helps isolate logic from views and makes it a little easier to test things that don't use DOM or Vue specific API's

Lastly, I did some typescript cleanup, and some cleanup / re-org in the API folder which will likely have some side effects, but from what I can tell everything is good.

Which issue(s) this PR fixes:

Related to #1058

@hay-kot hay-kot force-pushed the chore/frontend-testing-setup branch from a66ce8e to 1749fd6 Compare October 22, 2022 04:37
@hay-kot hay-kot force-pushed the chore/frontend-testing-setup branch from 07e2b8e to fc40c00 Compare October 22, 2022 19:24
@hay-kot hay-kot changed the title (WIP) chore: frontend testing setup chore: frontend testing setup Oct 22, 2022
@hay-kot hay-kot marked this pull request as ready for review October 22, 2022 19:42
@hay-kot hay-kot merged commit fcc5d99 into mealie-next Oct 22, 2022
@hay-kot hay-kot deleted the chore/frontend-testing-setup branch October 22, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant