-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: frontend testing setup #1739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a66ce8e
to
1749fd6
Compare
07e2b8e
to
fc40c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently there is no testing framework enabled for the frontend. This PR sets-up the basic implementation for unit testing. I have yet to figure out how to implement component mounting and testing the actual Vue Components, but I think this is going to be merged as is, and we can add component testing later on.
Additionally, I've moved some of the isolated modules to a new lib folder. This is a pattern I've adopted in a few other projects that provide a place to put some utility type packages but still provide a clear namespace and location. It also helps isolate logic from views and makes it a little easier to test things that don't use DOM or Vue specific API's
Lastly, I did some typescript cleanup, and some cleanup / re-org in the API folder which will likely have some side effects, but from what I can tell everything is good.
Which issue(s) this PR fixes:
Related to #1058