Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Add tesseract bin to container #1676

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

Miroito
Copy link
Contributor

@Miroito Miroito commented Sep 26, 2022

What type of PR is this?

  • bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

The recently merged OCR capability is unusable because the docker container is missing the Tesseract binary.
I have 0 experience with docker but I think this might fix it.

Special notes for your reviewer:

N/A

Testing

N/A

Release Notes

N/A

@hay-kot
Copy link
Collaborator

hay-kot commented Sep 26, 2022

Did you try building this container and checking if it worked with the new dependency?

@Miroito
Copy link
Contributor Author

Miroito commented Sep 26, 2022

Did you try building this container and checking if it worked with the new dependency?

I've tried running make docker-prod but I get an error down the line that I did not get the time to troubleshoot

edit: turns out dns resolution was failing for a token required to build the image... Deactivating my vpn enforcing certain dns servers did the trick but I have a new error now when poetry tries to install dependencies...

@Miroito
Copy link
Contributor Author

Miroito commented Oct 1, 2022

I made the docker image build by upgrading the version of poetry. With the previous version I ran into python-poetry/poetry#4210. (fixes #1691)
I have no idea how the current docker image successfully built with this problem existing...

I could run make docker-prod and this solution worked. I still have some doubts because somehow the data persisted through fresh builds even though I removed the images and ran system prune after each... Hopefully this is enough now.

More notes:
I've looked a bit deeper into the api Dockerfile and I don't really understand what this is supposed to accomplish?
RUN useradd -u 911 -U -d $MEALIE_HOME -s /bin/bash abc \
&& usermod -G users abc \

@hay-kot hay-kot changed the base branch from mealie-next to fit/images-and-ci October 3, 2022 00:10
@hay-kot hay-kot merged commit 552b892 into mealie-recipes:fit/images-and-ci Oct 3, 2022
hay-kot added a commit that referenced this pull request Oct 3, 2022
* bump cache version

* bump version

* delete template file

* maybe fix invalid CI?

* chain status command

* fix add tesseract bin to container & bump poetry (#1676)

* Add tesseract bin to container

* Add tesseract bin

Co-authored-by: Miroito <88556823+Miroito@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants