Merge pull request IQTLabs#30 from TrellixVulnTeam/main

CVE-2007-4559 Patch

ml-model/scripts/detection.py

@@ -324,7 +324,26 @@ def download_pretrained_model(filepaths):
     # open and extract tarfile
     tar_filepath = "/tf/models/research/deploy/" + filepaths["pretrained_checkpoint"]
     with tarfile.open(tar_filepath) as tar:
-        tar.extractall(path="/tf/models/research/deploy/")
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, path="/tf/models/research/deploy/")
 
     logging.info("Finished downloading pretrained model.")