Update check_status to better support different types of errors (goog…

…leapis#517)
me3eh · Feb 2, 2017 · e9d7e47 · e9d7e47
1 parent 88c22f7
commit e9d7e47
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 5 deletions.
diff --git a/lib/google/apis/core/api_command.rb b/lib/google/apis/core/api_command.rb
@@ -26,7 +26,11 @@ module Core
       class ApiCommand < HttpCommand
         JSON_CONTENT_TYPE = 'application/json'
         FIELDS_PARAM = 'fields'
-        RATE_LIMIT_ERRORS = %w(rateLimitExceeded userRateLimitExceeded)
+        ERROR_REASON_MAPPING = {
+          'rateLimitExceeded' => Google::Apis::RateLimitError,
+          'userRateLimitExceeded' => Google::Apis::RateLimitError,
+          'projectNotLinked' => Google::Apis::ProjectNotLinkedError
+        }
 
         # JSON serializer for request objects
         # @return [Google::Apis::Core::JsonRepresentation]
@@ -94,10 +98,12 @@ def check_status(status, header = nil, body = nil, message = nil)
             error = parse_error(body)
             if error
               message = sprintf('%s: %s', error['reason'], error['message'])
-              raise Google::Apis::RateLimitError.new(message,
-                                                     status_code: status,
-                                                     header: header,
-                                                     body: body) if RATE_LIMIT_ERRORS.include?(error['reason'])
+              raise ERROR_REASON_MAPPING[error['reason']].new(
+                message,
+                status_code: status,
+                header: header,
+                body: body
+              ) if ERROR_REASON_MAPPING.key?(error['reason'])
             end
             super(status, header, body, message)
           else

diff --git a/lib/google/apis/errors.rb b/lib/google/apis/errors.rb
@@ -61,6 +61,10 @@ class ClientError < Error
     class RateLimitError < Error
     end
 
+    # A 403 HTTP error occurred.
+    class ProjectNotLinkedError < Error
+    end
+
     # A 401 HTTP error occurred.
     class AuthorizationError < Error
     end

diff --git a/spec/google/apis/core/api_command_spec.rb b/spec/google/apis/core/api_command_spec.rb
@@ -159,6 +159,44 @@
     end
   end
 
+  context('with a project not linked response') do
+    let(:command) do
+      Google::Apis::Core::ApiCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
+    end
+
+    before(:example) do
+      json = <<EOF
+{
+ "error": {
+  "errors": [
+   {
+    "domain": "global",
+    "reason": "projectNotLinked",
+    "message": "The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console."
+   }
+  ],
+  "code": 403,
+  "message": "The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console."
+ }
+}
+EOF
+      stub_request(:get, 'https://www.googleapis.com/zoo/animals')
+        .to_return(status: [403, 'The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console.'], headers: {
+          'Content-Type' => 'application/json'
+        }, body: json)
+        .to_return(headers: { 'Content-Type' => 'application/json' }, body: %({}))
+    end
+
+    it 'should raise project not linked error' do
+      expect { command.execute(client) }.to raise_error(Google::Apis::ProjectNotLinkedError)
+    end
+
+    it 'should raise an error with the reason and message' do
+      expect { command.execute(client) }.to raise_error(
+        /projectNotLinked: The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console./)
+    end
+  end
+
   context('with a client error response') do
     let(:command) do
       Google::Apis::Core::ApiCommand.new(:get, 'https://www.googleapis.com/zoo/animals')