fix: Fail if configuration has no policies

me-viper · Sep 26, 2023 · 948464c · 948464c
1 parent c8eee1a
commit 948464c
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/OpaDotNet.Extensions.AspNetCore/ConfigurationPolicySource.cs b/src/OpaDotNet.Extensions.AspNetCore/ConfigurationPolicySource.cs
@@ -40,6 +40,7 @@ public ConfigurationPolicySource(
     /// <inheritdoc />
     protected override async Task<Stream?> CompileBundleFromSource(bool recompiling, CancellationToken cancellationToken = default)
     {
+        var hasSources = false;
         using var ms = new MemoryStream();
         var bundleWriter = new BundleWriter(ms);
 
@@ -48,16 +49,22 @@ public ConfigurationPolicySource(
             foreach (var (name, policy) in _policy.CurrentValue)
             {
                 if (!string.IsNullOrWhiteSpace(policy.DataJson))
-                    bundleWriter.WriteEntry(policy.DataJson, $"{policy.Package}/data.json");
+                    bundleWriter.WriteEntry(policy.DataJson, $"/{policy.Package}/data.json");
 
                 if (!string.IsNullOrWhiteSpace(policy.DataYaml))
-                    bundleWriter.WriteEntry(policy.DataYaml, $"{policy.Package}/data.yaml");
+                    bundleWriter.WriteEntry(policy.DataYaml, $"/{policy.Package}/data.yaml");
 
                 if (!string.IsNullOrWhiteSpace(policy.Source))
+                {
+                    hasSources = true;
                     bundleWriter.WriteEntry(policy.Source, $"/{policy.Package}/{name}.rego");
+                }
             }
         }
 
+        if (!hasSources)
+            throw new RegoCompilationException("Configuration has no policies defined");
+
         ms.Seek(0, SeekOrigin.Begin);
 
         var result = await Compiler.CompileStream(

diff --git a/tests/OpaDotNet.Extensions.AspNetCore.Tests/ConfigurationPolicySourceTests.cs b/tests/OpaDotNet.Extensions.AspNetCore.Tests/ConfigurationPolicySourceTests.cs
@@ -28,6 +28,25 @@ public ConfigurationPolicySourceTests(ITestOutputHelper output)
 
     private record UserPolicyInput([UsedImplicitly] string User);
 
+    [Fact]
+    public async Task NoPolicies()
+    {
+        var policyOptions = new OpaPolicyOptions();
+        var optionsMonitor = new PolicyOptionsMonitor(policyOptions);
+
+        using var compiler = new ConfigurationPolicySource(
+            new RegoInteropCompiler(
+                null,
+                _loggerFactory.CreateLogger<RegoInteropCompiler>()
+                ),
+            new OptionsWrapper<OpaAuthorizationOptions>(new()),
+            optionsMonitor,
+            _loggerFactory
+            );
+
+        await Assert.ThrowsAsync<RegoCompilationException>(() => compiler.StartAsync(CancellationToken.None));
+    }
+
     [Theory]
     [InlineData(2, "p1/t1/allow")]
     [InlineData(3, "p2/allow")]