Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized frame number #829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fightingdreamer
Copy link

Frame number was not initialised in AsyncWebSocketClient.
This was resulting in bogus frame number during first message.

example: one frame 2000 bytes

# first message
     ws: frame=1162280960 length=2000 index=0 chunk=528 final=1 opcode=2
     ws: frame=1162280960 length=2000 index=528 chunk=536 final=1 opcode=2
     ws: frame=1162280960 length=2000 index=1064 chunk=536 final=1 opcode=2
     ws: frame=1162280960 length=2000 index=1600 chunk=400 final=1 opcode=2

# first message (fixed)
     ws: frame=0 length=2000 index=0 chunk=528 final=1 opcode=2
     ws: frame=0 length=2000 index=528 chunk=536 final=1 opcode=2
     ws: frame=0 length=2000 index=1064 chunk=536 final=1 opcode=2
     ws: frame=0 length=2000 index=1600 chunk=400 final=1 opcode=2

@fightingdreamer
Copy link
Author

Related to #668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant