Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Adding Client Server example #76

Merged
merged 5 commits into from
Jul 24, 2018
Merged

Adding Client Server example #76

merged 5 commits into from
Jul 24, 2018

Conversation

IMAN4K
Copy link
Contributor

@IMAN4K IMAN4K commented Jan 3, 2018

Signed-off-by: Iman Ahmadvand iman72411@gmail.com (github: @IMAN4K)

@romansavrulin
Copy link

@IMAN4K please rename ClientServer/client.ino to ClientServer/ClientServer.ino so Travis could proceed

@hreintke
Copy link

hreintke commented Jan 8, 2018

Hi,

I think in examples one should use Library options and not direct SDK calls.

-> Ticker instead of os_timer_t

@IMAN4K
Copy link
Contributor Author

IMAN4K commented Jan 8, 2018

@hreintke
That's fine.
This is just an example with focus on TCP not the timing.
Anyone could pick whatever they prefer.
Anyway, you can commit after example get pushed to master.

@romansavrulin
Copy link

@IMAN4K , please take a look at Travis job output

Seems like it tries to compile both ClientServer.ino and server.ino in the same pass. The reason, as I can see is the arduino sketch layout rules. .ino files are per-project, and should be the one and the only in the project directory and has the same name as the directory.

Could you please separate client and server examples to different folders?

Please note, if you have common configuration to both project (e.g. config.h) you should copy it to both folders too.

@IMAN4K
Copy link
Contributor Author

IMAN4K commented Jan 8, 2018

@romansavrulin

The reason, as I can see is the arduino sketch layout rules. .ino files are per-project, and should be the one and the only in the project directory and has the same name as the directory

That's an odd thing! i was thinking for sketch as C++ source since they're using GCC as tool-chain for Arduino.
I'll modify it.

@romansavrulin
Copy link

@IMAN4K, for sure. I'm suffering a lot from it too. But while you are compiling with GCC in Arduino, you should play the rules Arduino guys decided to use to manage includes and other stuff.

@me-no-dev me-no-dev merged commit a313fc9 into me-no-dev:master Jul 24, 2018
@me-no-dev
Copy link
Owner

@IMAN4K sorry for the long delay! Thank you for those examples!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants