IPv6 support #105
Open
IPv6 support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is my attempt at adding a proper IPv6 support.
bindpart was pretty simple but theconnectone was a little bit trickier.I've ran the standard test suite that's configured for CI and they seem to be fine, I also ran a couple of tests on my own and they're fine too. If you have any ideas for additional tests or general comments about the code - feel free to comment - I'd be happy to work on this further. This commit does not change the API a whole lot but if you want me to write some examples - please do let me know.