ERC1155 ZKSync #168
Open
ERC1155 ZKSync #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing0012
approved these changes
Jan 23, 2025
|
good to know that solady has zksync ext. does it work for non-zksync chains? |
|
@nothing0012 I think it depends. This contract should, but code related to zksync-specific features (system contracts, account abstraction, bridging) won't and some EVM opcodes are inefficient on zksync and not implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, the solidity formatter hit some files.
Changes:
import {ERC1155} from "solady/src/tokens/ERC1155.sol";with
import {ERC1155} from "solady/src/tokens/ext/zksync/ERC1155.sol";