Update lib-go-databox to 0.5.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
+ Coverage 38.16% 42.9% +4.74%
=========================================
Files 7 8 +1
Lines 773 543 -230
=========================================
- Hits 295 233 -62
+ Misses 412 276 -136
+ Partials 66 34 -32
Continue to review full report at Codecov.
|
Sets up an arbiter client and store connection using the default values making thing a bit less complex
So apps launched with image complex-image-name-with-arch-amd64v8 can have a consistent name across platforms complex-image-name
Only the cmgr ever talks to the core-network so this should not be here. It also used functions from docker requiring a go get docker/docker which is very slow. This is not needed any more so apps and driver build more quickly ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now has a more logical structure and contains clients to wrap APIs for the core-network, core-arbiter and core-stores, which are used in the core components as well as in apps and drivers.
There will likely be more commits to this PR as the arbiter is about to be replaced and I may make changes as I port over apps to the new version to improve the libs usability for app and driver devs.