Deprecate ReactPackage.createNativeModules recommending using getModu…

…le instead (facebook#39339)

Summary:
Pull Request resolved: facebook#39339

Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native

changelog: [Android][Changed] Deprecating createNativeModules method from ReactPackage interface recommending using getModule instead in the new architecture of React Native

Reviewed By: cortinico

Differential Revision: D48992719

fbshipit-source-id: 9c863f25086c459ed374bd0c57868e4bbdbde196

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java

@@ -11,6 +11,7 @@
 import com.facebook.infer.annotation.Nullsafe;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.common.annotations.DeprecatedInNewArchitecture;
 import com.facebook.react.uimanager.UIManagerModule;
 import com.facebook.react.uimanager.ViewManager;
 import java.util.List;
@@ -37,9 +38,11 @@ public interface ReactPackage {
 
   /**
    * @param reactContext react application context that can be used to create modules
-   * @return list of native modules to register with the newly created catalyst instance
+   * @return list of native modules to register with the newly created catalyst instance This method
+   *     is deprecated in the new Architecture of React Native.
    */
   @NonNull
+  @DeprecatedInNewArchitecture
   List<NativeModule> createNativeModules(@NonNull ReactApplicationContext reactContext);
 
   /** @return a list of view managers that should be registered with {@link UIManagerModule} */